Fix GH-1132: Document mb_strlen invalid encoding behavior change in P…#5418
Conversation
| <entry>8.0.0</entry> | ||
| <entry> | ||
| Passing an invalid encoding now throws a | ||
| <classname>ValueError</classname>. Previously, the return value was |
There was a problem hiding this comment.
Please use <exceptionname>ValueError</exceptionname> instead.
And Previously, &false; was returned. makes more sense here since prior to 8.0, false was always returned on error.
https://github.com/php/php-src/blob/PHP-7.4.33/ext/mbstring/mbstring.c#L2503
There was a problem hiding this comment.
Done, @jordikroon . Switched to <exceptionname>ValueError</exceptionname> and updated to "Previously, &false; was returned." to match the PHP 7.4 source. Thanks.
|
Hi, i checked in php-src and the Currently only |
3 participants
Fixes #1132
Documents that passing an invalid encoding to
mb_strlen()had undefined behavior before PHP 8.0 (could returnfalse) and that as of PHP 8.0 aValueErroris thrown instead, as suggested in the issue discussion.